chore(release): pull release/v1.53.0 into main #2974

devops-github-rudderstack · 2024-01-08T04:49:54Z

👑 An automated PR

Bumps [actions/stale](https://github.com/actions/stale) from 8.0.0 to 9.0.0. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v8.0.0...v9.0.0) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Krishna Chaitanya <[email protected]>

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 4.1.1 to 5.1.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v4.1.1...v5.1.0) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Krishna Chaitanya <[email protected]>

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.9.1 to 3.0.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2.9.1...v3.0.0) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Krishna Chaitanya <[email protected]>

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 4.0.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3.7.0...v4.0.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Krishna Chaitanya <[email protected]>

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 4.1.1. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.5.3...v4.1.1) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fix: upgrade @aws-sdk/client-s3 from 3.370.0 to 3.438.0 Snyk has created this PR to upgrade @aws-sdk/client-s3 from 3.370.0 to 3.438.0. See this package in npm: https://www.npmjs.com/package/@aws-sdk/client-s3 See this project in Snyk: https://app.snyk.io/org/datamanagement/project/39f686fe-9e69-4343-a9ce-129e22bff288?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Sai Kumar Battinoju <[email protected]>

* chore: move clevertap, braze and am * chore: move intercom test cases * chore: add component test cases for marketo and sendgrid * chore: resolve conflicts

chore: add component test cases for ga4, stormly, facebook_conversion

* chore: add component test cases for some destinations * chore: add method to network.ts

* chore: added component test cases for desitnations * chore: added component test cases for wootric

* chore: add component test cases for some destinations * chore: added component test cases for desitnations * chore: decrease coverageThreshold in jest.config.js * chore: decrease coverageThreshold in jest.default.config.js

* feat: amplitude add support for unset * Update src/v0/destinations/am/transform.js Co-authored-by: Yashasvi Bajpai <[email protected]> * Update src/v0/destinations/am/transform.js Co-authored-by: Yashasvi Bajpai <[email protected]> * chore:comment addresed * Update transform.js * chore:comment addresed * chore: added docs * Update utils.js --------- Co-authored-by: Yashasvi Bajpai <[email protected]>

* chore: upgrade node to 18.19 * fix: image name --------- Co-authored-by: Yashasvi Bajpai <[email protected]>

* feat: handle improper type validation sync vulnerability * feat: addressed review comments

* chore: add endpoint labelsx1 * chore: add endpoint labelsx2 * Update src/v0/destinations/active_campaign/transform.js Co-authored-by: Sudip Paul <[email protected]> * Update src/v0/destinations/active_campaign/transform.js Co-authored-by: Sankeerth <[email protected]> * chore: fix monday path --------- Co-authored-by: Sudip Paul <[email protected]> Co-authored-by: Sankeerth <[email protected]>

chore: add endpoint labelsx3 Co-authored-by: Sudip Paul <[email protected]>

* fix: only new users to have default signUp date * fix: only new users to have default createDate * fix: small edit in comment * fix: small edit in comment * fix: small edit in comment * fix: review comments addressed

* feat(sprig): added user deletion support * chore: destination doc link added for reference * chore: code review changes * chore: code review changes

…2945) * fix: enhancement and version upgrade of garl * fix: migrating util to google utils and adding test cases * fix: small edit * Update src/v0/destinations/google_adwords_remarketing_lists/networkHandler.js Co-authored-by: Sudip Paul <[email protected]> * fix: edit test case description --------- Co-authored-by: Sudip Paul <[email protected]>

* feat: onboard new destination the trade desk * feat: onboard trade desk on transformer porxy * feat: add secret from metadata * refactor: remove secretKey from headers in utils * feat: using audienceId from config inplace of segmentName * test: added testcases * test: added testcases * refactor: prepareProxyRequest utility and added delivery test cases * test: add console log * refactor: address review comments * refactor: use existing utility to split batch on size * chore: added mocks * refactor: throw platform error

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4.0.0...v4.0.1) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…2.1.1 (#2931) chore(deps): bump SonarSource/sonarcloud-github-action Bumps [SonarSource/sonarcloud-github-action](https://github.com/sonarsource/sonarcloud-github-action) from 2.0.0 to 2.1.1. - [Release notes](https://github.com/sonarsource/sonarcloud-github-action/releases) - [Commits](SonarSource/sonarcloud-github-action@v2.0.0...v2.1.1) --- updated-dependencies: - dependency-name: SonarSource/sonarcloud-github-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…2962) fix: upgrade @aws-sdk/client-personalize from 3.414.0 to 3.470.0 Snyk has created this PR to upgrade @aws-sdk/client-personalize from 3.414.0 to 3.470.0. See this package in npm: https://www.npmjs.com/package/@aws-sdk/client-personalize See this project in Snyk: https://app.snyk.io/org/sandeep-L8FvsjCG7mBBqonjSmN48c/project/4b0f037e-0dab-4719-aeee-b46d2ae82119?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <[email protected]>

fix: upgrade @aws-sdk/lib-storage from 3.417.0 to 3.456.0 Snyk has created this PR to upgrade @aws-sdk/lib-storage from 3.417.0 to 3.456.0. See this package in npm: https://www.npmjs.com/package/@aws-sdk/lib-storage See this project in Snyk: https://app.snyk.io/org/sandeep-L8FvsjCG7mBBqonjSmN48c/project/4b0f037e-0dab-4719-aeee-b46d2ae82119?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <[email protected]>

coderabbitai · 2024-01-08T04:49:59Z

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

codecov · 2024-01-08T04:56:25Z

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (4e1a200) 87.42% compared to head (3b4ad42) 87.28%.

Files	Patch %	Lines
src/controllers/bulkUpload.ts	0.00%	4 Missing ⚠️
src/cdk/v2/destinations/the_trade_desk/utils.js	96.72%	2 Missing ⚠️
src/v0/destinations/active_campaign/transform.js	83.33%	2 Missing ⚠️
...c/v0/destinations/the_trade_desk/networkHandler.js	93.54%	2 Missing ⚠️
...google_adwords_remarketing_lists/networkHandler.js	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2974      +/-   ##
==========================================
- Coverage   87.42%   87.28%   -0.15%     
==========================================
  Files         860      872      +12     
  Lines       29486    29500      +14     
  Branches     6917     6865      -52     
==========================================
- Hits        25779    25749      -30     
- Misses       3366     3405      +39     
- Partials      341      346       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Revert "fix: tiktok add missing field brand (#2942)" This reverts commit ca76297. * chore: update changelog

sonarqubecloud · 2024-01-08T11:14:32Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

krishna2020 · 2024-01-08T09:39:55Z

src/cdk/v2/destinations/the_trade_desk/utils.js

+        }
+      });
+    } else {
+      errorResponseList.push(handleRtTfSingleEventError(input, error, {}));


@Gauravudia Does TradeDesk allows processing only record type events ? Is it not compatible with older flow of audienceList message type ?

Have the test case covered for unsupported message type too. Codecov already flagged,
Added lines #L84 - L85 were not covered by tests

Not compatible with audienceList. Since it is a new destination, So we onboarded it on record only.

Will raise the PR with testcase for unsupported message type.

krishna2020 · 2024-01-08T09:42:03Z

src/cdk/v2/destinations/the_trade_desk/utils.js

+  if (groupedInputs.record) {
+    const transformedRecordEvent = processRecordInputs(groupedInputs.record, destination);
+    respList.push(...transformedRecordEvent);
+  }


shouldn't we log or throw an error for easy debugging if event type other than record is sent to tradedesk ?

Will raise the PR with better error handling for this.

aashishmalik and others added 30 commits December 13, 2023 15:08

chore(release): pull main into develop post release v1.52.0 (#2908)

6426b73

Merge remote-tracking branch 'origin/main' into develop

62a43db

chore(release): pull main into develop post release v1.52.1 (#2914)

93b553a

chore: upgrade delete old branches action

52e5a0d

chore(release): pull main into develop post release v1.52.2 (#2924)

69ba1b6

Update create-hotfix-branch.yml

c875ad4

chore(release): pull main into develop post release v1.52.3 (#2936)

eea6511

chore: move destinations to component test suite (#2894)

a593192

* chore: move clevertap, braze and am * chore: move intercom test cases * chore: add component test cases for marketo and sendgrid * chore: resolve conflicts

chore: add component test cases for destinations without mock (#2910)

3676039

chore: add component test cases for ga4, stormly, facebook_conversion

chore: add component test cases for some destinations part1 (#2915)

d0e24d3

* chore: add component test cases for some destinations * chore: add method to network.ts

chore: added component test cases for desitnations part3 (#2927)

99613a0

* chore: added component test cases for desitnations * chore: added component test cases for wootric

fix: tiktok add missing field brand (#2942)

ca76297

chore: upgrade node to 18.19 (#2940)

efca60c

* chore: upgrade node to 18.19 * fix: image name --------- Co-authored-by: Yashasvi Bajpai <[email protected]>

chore(release): pull main into develop post release v1.52.4 (#2958)

66a5390

feat: pass ip details for factorsAI (#2925)

970d37d

feat: handle improper type validation sync vulnerability (#2937)

7d734f0

* feat: handle improper type validation sync vulnerability * feat: addressed review comments

feat: move intercom to routerTransform (#2964)

48e4036

chore: add endpoint labels (#2951)

5dade89

chore: add endpoint labelsx3 Co-authored-by: Sudip Paul <[email protected]>

fix: error handling when payload contains toString as key (#2954)

e002093

feat(sprig): added user deletion support (#2886)

e0c225d

* feat(sprig): added user deletion support * chore: destination doc link added for reference * chore: code review changes * chore: code review changes

shrouti1507 and others added 8 commits January 4, 2024 15:04

fix: version upgrade of gaec from 14 to 15 (#2966)

8bada4b

chore(release): 1.53.0

46c8490

devops-github-rudderstack requested review from a team and sivashanmukh as code owners January 8, 2024 04:49

devops-github-rudderstack requested review from koladilip and sandeepdsvs January 8, 2024 04:49

achettyiitr previously approved these changes Jan 8, 2024

View reviewed changes

revert: fix: tiktok add missing field brand (#2977)

3b4ad42

* Revert "fix: tiktok add missing field brand (#2942)" This reverts commit ca76297. * chore: update changelog

anantjain45823 dismissed achettyiitr’s stale review via 3b4ad42 January 8, 2024 11:08

koladilip approved these changes Jan 9, 2024

View reviewed changes

sanpj2292 approved these changes Jan 9, 2024

View reviewed changes

anantjain45823 requested a review from achettyiitr January 9, 2024 06:29

achettyiitr approved these changes Jan 9, 2024

View reviewed changes

anantjain45823 merged commit 6a959d4 into main Jan 9, 2024
18 of 19 checks passed

anantjain45823 deleted the release/v1.53.0 branch January 9, 2024 06:32

krishna2020 reviewed Jan 11, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(release): pull release/v1.53.0 into main #2974

chore(release): pull release/v1.53.0 into main #2974

devops-github-rudderstack commented Jan 8, 2024

coderabbitai bot commented Jan 8, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

codecov bot commented Jan 8, 2024 •

edited

Loading

sonarqubecloud bot commented Jan 8, 2024

krishna2020 Jan 8, 2024

krishna2020 Jan 8, 2024

Gauravudia Jan 11, 2024

Gauravudia Jan 11, 2024

krishna2020 Jan 8, 2024

Gauravudia Jan 11, 2024

chore(release): pull release/v1.53.0 into main #2974

chore(release): pull release/v1.53.0 into main #2974

Conversation

devops-github-rudderstack commented Jan 8, 2024

coderabbitai bot commented Jan 8, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

codecov bot commented Jan 8, 2024 • edited Loading

Codecov Report

sonarqubecloud bot commented Jan 8, 2024

Quality Gate passed

krishna2020 Jan 8, 2024

Choose a reason for hiding this comment

krishna2020 Jan 8, 2024

Choose a reason for hiding this comment

Gauravudia Jan 11, 2024

Choose a reason for hiding this comment

Gauravudia Jan 11, 2024

Choose a reason for hiding this comment

krishna2020 Jan 8, 2024

Choose a reason for hiding this comment

Gauravudia Jan 11, 2024

Choose a reason for hiding this comment

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented Jan 8, 2024 •

edited

Loading